chore: add Tip Calculator #1277 #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayushsgithub is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
priyankarpal
changed the title
priyankarpal
requested changes
Oct 8, 2023
ayushsgithub
force-pushed
the
tip-calculator
branch
from
8bdd5c5
to
4266b7a
Compare
priyankarpal
added
hacktoberfest
hacktoberfest-accepted
atapas
requested changes
Oct 16, 2023
src/plays/tip-calculator/styles.css
Outdated
| @@ -0,0 +1,4 @@ | |||
| /* enter stlyes here */ | |||
| :root { | |||
There was a problem hiding this comment.
@ayushsgithub Let's not override the :root selector. Could you please add a style in your play level instead? Rest of the changes look good?
There was a problem hiding this comment.
Hey @atapas sir, removed the root selector as per the required changes
ayushsgithub
force-pushed
the
tip-calculator
branch
from
bd41710
to
8444974
Compare
@atapas Thank You so much sir, I'm fan of your work and content. |
|
@priyankarpal there's a request, can you please add hacktoberfest-accepted label to it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Tip Calculator in the ReactPlay
Fixes #1277
Type of change
How Has This Been Tested?
Tested Manually
Checklist:
Screenshots or example output