Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: play search result summary #1350

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Conversation

janvi01
Copy link
Contributor

@janvi01 janvi01 commented Oct 17, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added Search Result Summary.
For example - we searched for "calcu" term. It should show "4 results for plays matching calcu sorted by Newest" below the search bar.

Fixes #1325

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I tested it locally on my development server.

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Screenshot 2023-10-17 at 1 33 39 PM

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit cf77432
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/654145592626a6000868be44
😎 Deploy Preview https://deploy-preview-1350--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are issues with responsiveness

image

@priyankarpal priyankarpal added the changes required need to change some thing label Oct 17, 2023
@janvi01
Copy link
Contributor Author

janvi01 commented Oct 18, 2023

@priyankarpal fixed it

@janvi01
Copy link
Contributor Author

janvi01 commented Oct 20, 2023

@atapas Kindly review.

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks

src/common/playlists/PlayList.jsx Outdated Show resolved Hide resolved
src/common/playlists/PlayList.jsx Outdated Show resolved Hide resolved
src/common/playlists/PlayList.jsx Outdated Show resolved Hide resolved
@Sachin-chaurasiya
Copy link
Member

@priyankarpal , please do the final review and merge it.

@priyankarpal priyankarpal removed the changes required need to change some thing label Nov 1, 2023
@priyankarpal priyankarpal merged commit e3d1c48 into reactplay:main Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add play search result summary
3 participants