Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: added the animation on home page #1364

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

letscodedanish
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This PR fixes the animation on home page.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1262

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit d7395b5
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/653bb2e36c2e610008a44b2e
😎 Deploy Preview https://deploy-preview-1364--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal priyankarpal changed the title [Feature}:we have added the animation on home page style: added the animation on home page Oct 22, 2023
@priyankarpal priyankarpal added waiting for reviewers hacktoberfest hacktoberfest-accepted hacktoberfest-accepted 💻 aspect: code Concerns the software code in the repository labels Oct 22, 2023
@priyankarpal
Copy link
Member

@letscodedanish please provide suitable commit messages in the future.
image

@priyankarpal
Copy link
Member

there are bugs! if I hover outside to the icon it's still changing the bg color. Also, please add a smooth transition

2023-10-22_22-56-43.mp4

@letscodedanish
Copy link
Contributor Author

fixed the issue @priyankarpal

bandicam.2023-10-22.23-22-42-178.mp4

@letscodedanish
Copy link
Contributor Author

please review @priyankarpal

@priyankarpal
Copy link
Member

please review @priyankarpal

I already approved the changes let's wait for the other maintainer

@atapas atapas merged commit 777bb90 into reactplay:main Oct 27, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository hacktoberfest hacktoberfest-accepted hacktoberfest-accepted ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Requesting Animations on the Home Page
3 participants