-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: home component refactoring #1395
Conversation
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
@priyankarpal @Sachin-chaurasiya could you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @v4xsh 🙌🏻,
Thanks for the contributions ✨
yeah let me check |
No problem. Looking forward to contribute more @Sachin-chaurasiya :) |
@atapas please deploy & check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🎉
Description
The Home.jsx component in src/common/home is being refactored to enhance code readability and maintainability. The primary motivation is to improve developer experience by breaking down the component into smaller, more focused components. Folder Structure:
home/
┣ Contributors.jsx
┣ home.css
┣ Home.jsx
┣ HomeBanner.jsx
┣ HomeContent.jsx
┣ HomeContributors.jsx
┣ HomeFeatures.jsx
┣ HomeIdeas.jsx
┣ HomePlays.jsx
┣ HomeSponsors.jsx
┣ HomeTestimonials.jsx
┣ index.js
┗ Sponsors.jsx
Fixes #1384
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The refactored code has been thoroughly tested using the
npm run build
script to ensure its compatibility and reliability.Checklist:
Screenshots or example output