-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Play Password Generator #143
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Angryman18 Great, could you please open an issue for this one? |
how do i do that? im not so good with github yet. |
Added #144 please add the relevant details. |
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Angryman18 Thanks for adding this play. Very neat. I have a few review comments. Once you take care, we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Angryman18 Yayy, Looks good.
@all-contributors please add @Angryman18 for Code |
I've put up a pull request to add @Angryman18! 🎉 |
@Angryman18 Thanks for your first contribution to the project. Looking for more to come, yay 😀. If you are planning to share your contribution experience anywhere publicly, please tag our Twitter handle(https://twitter.com/ReactPlayIO). Also, don't be shy to support the project with a star. Keep going. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: