Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Play Password Generator #143

Merged
merged 2 commits into from
May 6, 2022
Merged

React Play Password Generator #143

merged 2 commits into from
May 6, 2022

Conversation

Angryman18
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 5, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 6, 2022 at 2:59AM (UTC)

@atapas
Copy link
Member

atapas commented May 5, 2022

@Angryman18 Great, could you please open an issue for this one?

@Angryman18
Copy link
Member Author

@Angryman18 Great, could you please open an issue for this one?

how do i do that? im not so good with github yet.

@atapas atapas linked an issue May 5, 2022 that may be closed by this pull request
@atapas atapas self-requested a review May 5, 2022 12:16
@atapas
Copy link
Member

atapas commented May 5, 2022

@Angryman18 Great, could you please open an issue for this one?

how do i do that? im not so good with github yet.

Added #144

please add the relevant details.

@Angryman18
Copy link
Member Author

@Angryman18 Great, could you please open an issue for this one?

how do i do that? im not so good with github yet.

Added #144

please add the relevant details.

added

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Angryman18 Thanks for adding this play. Very neat. I have a few review comments. Once you take care, we are good to go.

src/plays/password-generator/PasswordGenerator.jsx Outdated Show resolved Hide resolved
src/plays/password-generator/PasswordGenerator.jsx Outdated Show resolved Hide resolved
src/plays/password-generator/Readme.md Outdated Show resolved Hide resolved
src/plays/password-generator/password-generator-style.css Outdated Show resolved Hide resolved
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Angryman18 Yayy, Looks good.

@atapas atapas merged commit c2b8e3f into reactplay:main May 6, 2022
@atapas
Copy link
Member

atapas commented May 6, 2022

@all-contributors please add @Angryman18 for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @Angryman18! 🎉

@atapas
Copy link
Member

atapas commented May 6, 2022

@Angryman18 Thanks for your first contribution to the project. Looking for more to come, yay 😀.

If you are planning to share your contribution experience anywhere publicly, please tag our Twitter handle(https://twitter.com/ReactPlayIO). Also, don't be shy to support the project with a star. Keep going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Create a Password Generator
2 participants