Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: navbar's social icons items #1454

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

Shivam-Katare
Copy link
Contributor

Description

Refactor the navbar's social icons code. Removed the repetition part, and instead of that used the mapping to display all icons.

Fixes #1448

Type of change

  • Code Refactoring

How Has This Been Tested?

  • Tested this change over Chrome Browser and Microsoft Edge

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Screenshots or example output

image

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit f59e5a8
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65ce179bf96e8d0008fa003e
😎 Deploy Preview https://deploy-preview-1454--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Shivam-Katare
Copy link
Contributor Author

@priyankarpal, let me know if any changes are required in it.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename all link to NavLink @Shivam-Katare

src/common/header/HeaderNav.jsx Outdated Show resolved Hide resolved
src/common/header/HeaderNav.jsx Outdated Show resolved Hide resolved
src/common/header/HeaderNav.jsx Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added waiting for reviewers changes required need to change some thing 🛠 goal: refactor need to refactor codebase labels Feb 14, 2024
@priyankarpal priyankarpal changed the title Refactor the navbar's social icons refactor: navbar's social icons items Feb 15, 2024
@Shivam-Katare
Copy link
Contributor Author

@priyankarpal, I renamed all links to NavLinks and also, Rename the icon to Icon in NavLink mapping to stick to the PascalCase convention for JSX components

@priyankarpal
Copy link
Member

@priyankarpal, I renamed all links to NavLinks and also, Rename the icon to Icon in NavLink mapping to stick to the PascalCase convention for JSX components

thank you

@priyankarpal priyankarpal removed the changes required need to change some thing label Feb 15, 2024
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit 2bab7a6 into reactplay:main Feb 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 goal: refactor need to refactor codebase ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: header social items
2 participants