Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ Position of the Banner #1471

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Conversation

Akshaygore1
Copy link
Contributor

Changed the Alignment of the Banner Content
Screenshot 2024-02-24 at 21 00 42

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit f713043
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65da0ca50ec50800082aa826
😎 Deploy Preview https://deploy-preview-1471--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit 98a37da into reactplay:main Feb 24, 2024
5 checks passed
@priyankarpal
Copy link
Member

hello @Akshaygore1 thanks for the pull request. I appreciate your work. a suggestion that when you open a pull request please add the issue number to the PR description also we follow conventional commits so use the format. also, check the conventional commits docs https://www.conventionalcommits.org/en/v1.0.0/

example:

- Fix/Position of the Banner #1471
+ fix: banner position #1471

@Akshaygore1
Copy link
Contributor Author

hello @Akshaygore1 thanks for the pull request. I appreciate your work. a suggestion that when you open a pull request please add the issue number to the PR description also we follow conventional commits so use the format. also, check the conventional commits docs https://www.conventionalcommits.org/en/v1.0.0/

example:

- Fix/Position of the Banner #1471
+ fix: banner position #1471

Thanks For Feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants