Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the header items alignment #1475

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

Shivam-Katare
Copy link
Contributor

Description

Fixed the header items alignment and made it responsive to make it flexible for all screen sizes

Fixes #1473

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I tested it on Chrome and Edge browser

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

Screenshots or example output

Screenshot (1688)
Screenshot (1689)
Screenshot (1690)
Screenshot (1691)
Screenshot (1692)
Screenshot (1693)

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit b81de51
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65dea859c2af050009c9926e
😎 Deploy Preview https://deploy-preview-1475--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@Shivam-Katare
Copy link
Contributor Author

Hey @priyankarpal, I raised the PR, you can review it now. Let me know if any changes are required in it.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit ca54111 into reactplay:main Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: fix header items alignment
2 participants