Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(currency-converter): implementing currency converter with real-time rate fetching #1492

Merged
merged 2 commits into from
May 9, 2024

Conversation

Sabbir2809
Copy link
Contributor

@Sabbir2809 Sabbir2809 commented May 7, 2024

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Copy link

netlify bot commented May 7, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 227050d
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/663bb2215e4b24000758a976
😎 Deploy Preview https://deploy-preview-1492--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an ui issue please fix it

Screenshot_2024-05-08_15-08-42

src/plays/currencyconverter/Readme.md Outdated Show resolved Hide resolved
src/plays/currencyconverter/styles.css Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added the changes required need to change some thing label May 8, 2024
@Sabbir2809
Copy link
Contributor Author

fix(currencyConverter): resolve ui issue

@Sabbir2809 Sabbir2809 closed this May 9, 2024
@Sabbir2809 Sabbir2809 reopened this May 9, 2024
@priyankarpal priyankarpal added play request New Play Request. and removed changes required need to change some thing labels May 9, 2024
@priyankarpal priyankarpal merged commit 68ff1fd into reactplay:main May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
play request New Play Request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants