-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netlify card game #163
netlify card game #163
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Angryman18 Super Play.
Posted some comments.
@Angryman18 When you create a PR, please fill the details like what is the play about, issue number, etc. It will help in tracking. Could you please update the description of the PR? |
Ok. on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Angryman18 It is fine code review perspective.
I am just wondering, it will be good to put some text in the UI by helping users how to play this game. All may not be aware of it, what say?
ok looking forward to add some. |
Great improvement, almost there.. Can we make the last stage button and done to close the modal? Like user traversed and done.. also a X at the top right to close it explicitly.. I know clicking it out closes it but that is not an intuitive UX. |
Its added. |
sry forgot to link the function. its done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
Dependency
sass compiler package "node-sass" is added