Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify card game #163

Merged
merged 5 commits into from
May 11, 2022
Merged

netlify card game #163

merged 5 commits into from
May 11, 2022

Conversation

Angryman18
Copy link
Member

@Angryman18 Angryman18 commented May 9, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code

Dependency

sass compiler package "node-sass" is added

@vercel
Copy link

vercel bot commented May 9, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 14, 2022 at 7:46AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Angryman18 Super Play.

Posted some comments.

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/netlify-card-game/NetlifyCardGame.jsx Outdated Show resolved Hide resolved
src/plays/netlify-card-game/NetlifyCardGame.jsx Outdated Show resolved Hide resolved
src/plays/netlify-card-game/NetlifyCardGame.scss Outdated Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented May 10, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Angryman18 When you create a PR, please fill the details like what is the play about, issue number, etc. It will help in tracking. Could you please update the description of the PR?

@Angryman18
Copy link
Member Author

Ok. on it.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Angryman18 It is fine code review perspective.

I am just wondering, it will be good to put some text in the UI by helping users how to play this game. All may not be aware of it, what say?

@atapas
Copy link
Member

atapas commented May 10, 2022

Finally, did it with an average performance 😁

image

@Angryman18
Copy link
Member Author

@Angryman18 It is fine code review perspective.

I am just wondering, it will be good to put some text in the UI by helping users how to play this game. All may not be aware of it, what say?

ok looking forward to add some.

@Angryman18
Copy link
Member Author

Finally, did it with an average performance grin

image

i have added the guidence section.

@atapas
Copy link
Member

atapas commented May 10, 2022

Finally, did it with an average performance grin
image

i have added the guidence section.

Great improvement, almost there..

image

Can we make the last stage button and done to close the modal? Like user traversed and done.. also a X at the top right to close it explicitly.. I know clicking it out closes it but that is not an intuitive UX.

@Angryman18
Copy link
Member Author

Its added.

@Angryman18
Copy link
Member Author

sry forgot to link the function. its done now

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@atapas atapas merged commit 2b4cc63 into reactplay:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants