-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a Simple and Fun Quiz App #170
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
Its really a dirty work and dirty code also. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very Amazing
This is one of the most incredible play I've seen! I shall start doing code reviews soon. |
Give me the reviewing and merging i am free |
Thanks. I see a bug. Will fix at next push. |
sorry i was mistaken about the bug. i think its working good. although i fixed a "key" was missing while mapping array. |
@Angryman18 Could you please create an issue for the play and associate with the PR to start the review? |
Created sir. |
Thanks but it was not done correctly. So next time,
|
ah. sorry about that. not very good on github yet but i learned a lot in recent days. |
Please go ahead and finish the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, @koustov please finish your review too. |
Started reviewing. I will finish it soon. |
@Angryman18 this is a great play ❤. I am fully energized to see the granularity maintained here. |
ok i will fix by night |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions added. also please notify once you are done with all comments.
Look like we are close to getting done with the comments. Can't wait to see this one crossing the border... |
@Angryman18 is it ready to be reviewed one last time? Note: Please reply to every comment. In fact, if you disagree with the suggestion given, just respond with reasoning. I want to resolve all conversations before approving any PR, this will be really helpful for any future tracking. |
i think the required changes are made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: