Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create calendar react-play #198

Merged
merged 9 commits into from
May 23, 2022
Merged

Create calendar react-play #198

merged 9 commits into from
May 23, 2022

Conversation

vincentBCP
Copy link
Contributor

@vincentBCP vincentBCP commented May 19, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

A simple calendar app to add, update, and delete events.

Dependecies:

  • date-fns
  • lodash

Fixes # (issue) #199

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 19, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

@vincentBCP
Copy link
Contributor Author

Review ready

@atapas
Copy link
Member

atapas commented May 19, 2022

@vincentBCP kindly edit and update the PR description.

@vincentBCP
Copy link
Contributor Author

@vincentBCP kindly edit and update the PR description.

Updated the PR description.

@atapas
Copy link
Member

atapas commented May 19, 2022

@vincentBCP kindly edit and update the PR description.

Updated the PR description.

Thanks @vincentBCP. You also need to create the issue for this play. I have done it: #199

Could you please check and add a bit about the play there? Thanks. We will start the review shortly.

@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 22, 2022 at 2:15PM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentBCP It is a cool play. Just played around with the preview URL. Looks awesome.

I have provided my initial review comments. @koustov will jump into doing the reviews of it as well.

One thing I noticed is, that the UI breaks a bit on mobile. If you can take care of the responsiveness as well, will be great.
image

src/plays/calendar/Readme.md Show resolved Hide resolved
src/plays/calendar/Context.tsx Outdated Show resolved Hide resolved
src/plays/calendar/Context.tsx Outdated Show resolved Hide resolved
src/plays/calendar/Calendar.tsx Outdated Show resolved Hide resolved
src/plays/calendar/Calendar.scss Show resolved Hide resolved
@vincentBCP
Copy link
Contributor Author

Thanks for the review @atapas . I'll work on the suggestions and issues.

@vincentBCP
Copy link
Contributor Author

Review ready

@atapas
Copy link
Member

atapas commented May 19, 2022

@vincentBCP Would you take up validation for cases like this? Like start date is ahead of the end date?

image

@vincentBCP
Copy link
Contributor Author

@vincentBCP Would you take up validation for cases like this? Like start date is ahead of the end date?

image

Sure. I'll add this validation.

@vincentBCP
Copy link
Contributor Author

@vincentBCP Would you take up validation for cases like this? Like start date is ahead of the end date?
image

Sure. I'll add this validation.

@atapas

I already pushed the changes for time validation, endTime should not be before the startTime now.
I just want to clarify, because I also got confused. The screenshot is correct the event is May 01 from 12:22 PM (noon) to 11:22 PM (evening). Tho, time range should be within the 24hr of the selected (date) only, because there is no feature implemented to create event the spans multiple days.

src/plays/calendar/Calendar.scss Outdated Show resolved Hide resolved
src/plays/calendar/Calendar.scss Show resolved Hide resolved
src/plays/calendar/ModalContainer.tsx Outdated Show resolved Hide resolved
src/plays/calendar/Context.tsx Outdated Show resolved Hide resolved
src/plays/calendar/Context.tsx Outdated Show resolved Hide resolved
src/plays/calendar/CalendarEventsMore.tsx Outdated Show resolved Hide resolved
src/plays/calendar/Calendar.scss Show resolved Hide resolved
@vincentBCP
Copy link
Contributor Author

Thanks for the review @koustov . I'll be working on request changes.

@vincentBCP
Copy link
Contributor Author

Review ready

koustov
koustov previously approved these changes May 21, 2022
Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

atapas
atapas previously approved these changes May 22, 2022
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atapas
Copy link
Member

atapas commented May 22, 2022

@vincentBCP Please resolve the merge conflicts

@vincentBCP vincentBCP dismissed stale reviews from atapas and koustov via 88f101b May 22, 2022 14:12
@vincentBCP
Copy link
Contributor Author

Resolved merge conflicts.

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atapas atapas merged commit 2513a4f into reactplay:main May 23, 2022
@atapas
Copy link
Member

atapas commented May 23, 2022

@all-contributors please add @vincentBCP for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @vincentBCP! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: A simple calendar app to add, update, and delete events.
3 participants