Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new play - Counter #20

Merged
merged 2 commits into from
Mar 1, 2022
Merged

added new play - Counter #20

merged 2 commits into from
Mar 1, 2022

Conversation

murtuzaalisurti
Copy link
Member

@murtuzaalisurti murtuzaalisurti commented Feb 28, 2022 •
edited
Loading

Description

Added a new play named Counter

Fixes #19

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code

@vercel
Copy link

vercel bot commented Feb 28, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/3hSsaNkKrtBgMWWh9orLe3h6iUhY
✅ Preview: https://react-play-git-fork-murtuzaalisurti-main-atapas.vercel.app

@atapas atapas changed the title added new play added new play - Counter Mar 1, 2022
atapas
atapas reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtuzaalisurti A few comments

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/meta/play-meta.js Outdated Show resolved Hide resolved
atapas
atapas approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Putting the play.

@atapas atapas merged commit 5f2bf1e into reactplay:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas atapas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new play - Counter
2 participants
@murtuzaalisurti @atapas