Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added feature to allow users to select preferred styling lang #209

Merged

Conversation

naiknareshh
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This feature allows user to select preferred styling language while creating the play. an empty 'css' or 'scss' file will be automatically added in their play directory based on the selection. No dependencies were added for this change.

Fixes #205

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  1. Create new plays and alternatively select 'css' and 'scss' when asked for 'Styling to be used (css/scss):'
  2. Validate if expected file is getting created in your play directory
  3. Validate that expected file type is getting imported in your JSX file

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 21, 2022 at 6:06AM (UTC)

@naiknareshh
Copy link
Contributor Author

This is Ready for Review :)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naiknareshh for picking this up.

Review comments given.

If you could post some screenshots of your testing would be great.

Additionally, you need to update the CREATE PLAY Read me file to include this option and change the screenshot there. Please check https://github.com/atapas/react-play/blob/main/CREATE-PLAY.md#%EF%B8%8F-steps-to-create-a-play

plop-templates/component_ts.hbs Outdated Show resolved Hide resolved
plopfile.js Outdated Show resolved Hide resolved
plopfile.js Outdated Show resolved Hide resolved
@naiknareshh naiknareshh force-pushed the feature-allow-styling-lang-selection branch from efba61d to 8479c97 Compare May 21, 2022 05:30
@naiknareshh
Copy link
Contributor Author

Testing Steps

Step 1: Validate 'Style to be used' question is queued up as expected

image

Step 2: Validate the files are getting created as expected and without any errors in the console

image

Step 3: Validate proper import statement is added in the JSX file

image

Step 4: Add some styles to some existing element

image

image

Step 5: Validate the styles are reflected properly on the play without any issues

image

@naiknareshh
Copy link
Contributor Author

@atapas All comments have been incorporated, please review and let me know if there is anything.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naiknareshh Looks good to me

@atapas atapas merged commit 33d1711 into reactplay:main May 21, 2022
@atapas
Copy link
Member

atapas commented May 21, 2022

@all-contributors please add @naiknareshh for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @naiknareshh! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Allow selection of preferred styling language
3 participants