Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the change directory command in the documentation #230

Merged
merged 6 commits into from
May 25, 2022

Conversation

hasnainmakada-99
Copy link
Contributor

@hasnainmakada-99 hasnainmakada-99 commented May 24, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added the change directory command in the official documentation so the users can directly operate it from the terminal

Fixes #231

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Seen the readme on Vs Code

Checklist:

  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 25, 2022 at 7:03AM (UTC)

@atapas
Copy link
Member

atapas commented May 24, 2022

@hasnainmakada-99 Please create an issue for this one.

README.md Outdated Show resolved Hide resolved
@hasnainmakada-99
Copy link
Contributor Author

Sure tapas sir

@atapas
Copy link
Member

atapas commented May 24, 2022

Sure tapas sir

Please take care of the review comment

@hasnainmakada-99
Copy link
Contributor Author

Means sir ?

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the string as I suggested.

@hasnainmakada-99
Copy link
Contributor Author

Please update the string as I suggested.

I've already updated that @atapas sir

@hasnainmakada-99
Copy link
Contributor Author

Please update the string as I suggested.

I've already updated that @atapas sir

So sorry @atapas sir I've forgot to put a dash between folder - name. So sorry

@atapas
Copy link
Member

atapas commented May 24, 2022

Please update the string as I suggested.

I've already updated that @atapas sir

So sorry @atapas sir I've forgot to put a dash between folder - name. So sorry

@hasnainmakada-99 This is what I see in the diff

image

But I had suggested this

Please change the directory after cloning the repository using the cd <folder-name> command.

@hasnainmakada-99
Copy link
Contributor Author

Yes sir it was my mistake I'll do it as you suggested

@atapas
Copy link
Member

atapas commented May 25, 2022

Yes sir it was my mistake I'll do it as you suggested

I still do not see your changes as I suggested. Could you please go to file changed tab and confirm? Mostly you are not pushing your changes, just committing.

@hasnainmakada-99

@hasnainmakada-99
Copy link
Contributor Author

Yes sir it was my mistake I'll do it as you suggested

I still do not see your changes as I suggested. Could you please go to file changed tab and confirm? Mostly you are not pushing your changes, just committing.

@hasnainmakada-99

image

see sir here are the changes

@atapas
Copy link
Member

atapas commented May 25, 2022

Yes sir it was my mistake I'll do it as you suggested

I still do not see your changes as I suggested. Could you please go to file changed tab and confirm? Mostly you are not pushing your changes, just committing.
@hasnainmakada-99

image

see sir here are the changes

I see that but that is not the text I suggested in my review comment above.

I had suggested this text:

Please change the directory after cloning the repository using the cd <folder-name> command.

@hasnainmakada-99
Copy link
Contributor Author

@atapas sir now I've updated that string

README.md Outdated Show resolved Hide resolved
@atapas atapas merged commit 234deb5 into reactplay:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add: Change directory command in the official documentation
2 participants