Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typo "change" #237

Merged
merged 1 commit into from
May 29, 2022
Merged

fixed typo "change" #237

merged 1 commit into from
May 29, 2022

Conversation

ishrarg
Copy link
Contributor

@ishrarg ishrarg commented May 28, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

fixed change typo in dynamic-routes play

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@vercel
Copy link

vercel bot commented May 28, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 28, 2022 at 2:32PM (UTC)

@atapas atapas self-requested a review May 28, 2022 15:59
@atapas atapas merged commit d737c7a into reactplay:main May 29, 2022
@atapas
Copy link
Member

atapas commented May 29, 2022

@all-contributors please add @ishrarg for Code

@allcontributors allcontributors bot mentioned this pull request May 29, 2022
Merged
@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @ishrarg! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas atapas approved these changes

Assignees

@ishrarg ishrarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ishrarg @atapas @koustov