Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new play - flip-card #261

Merged
merged 7 commits into from
Jun 5, 2022
Merged

Conversation

Deepak8717
Copy link
Member

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

New play/ Flip-card-effect
It is a simple play to demonstrate the flipping effect of the card. On clicking of any card it flips the card on y axis towards backside.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
self test

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Jun 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jun 4, 2022 at 4:01AM (UTC)

@atapas
Copy link
Member

atapas commented Jun 1, 2022

You should create an issue for it with all relevant details @Deepak8717

@atapas atapas self-requested a review June 1, 2022 13:58
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deepak8717 Review comments

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/flip-card-effect/FlipCardEffect.css Outdated Show resolved Hide resolved
src/plays/flip-card-effect/FlipCardEffect.jsx Show resolved Hide resolved
src/plays/flip-card-effect/FlipCardEffect.jsx Outdated Show resolved Hide resolved
@Deepak8717
Copy link
Member Author

@atapas please check

@Deepak8717
Copy link
Member Author

@atapas done

@Deepak8717
Copy link
Member Author

@atapas @koustov please check again

atapas
atapas previously approved these changes Jun 3, 2022
@Deepak8717
Copy link
Member Author

@atapas is there anything else pending ?

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/flip-card-effect/Card.jsx Show resolved Hide resolved
src/plays/flip-card-effect/FlipCardEffect.css Show resolved Hide resolved
src/plays/flip-card-effect/FlipCardEffect.css Show resolved Hide resolved
src/plays/flip-card-effect/FlipCardEffect.jsx Show resolved Hide resolved
@Deepak8717
Copy link
Member Author

@joshi-kaushal @atapas @koustov Please review

@atapas
Copy link
Member

atapas commented Jun 5, 2022

@koustov i am done with the review. please complete.

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atapas atapas merged commit be54a11 into reactplay:main Jun 5, 2022
@Deepak8717 Deepak8717 deleted the new/flip-card-effect branch June 5, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants