Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar filter bug fix #344

Merged
merged 4 commits into from
Jun 25, 2022
Merged

Conversation

ShivamBhasin2002
Copy link
Contributor

@ShivamBhasin2002 ShivamBhasin2002 commented Jun 24, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #302

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Jun 24, 2022

@ShivamBhasin2002 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 0:04AM (UTC)

@koustov
Copy link
Member

koustov commented Jun 24, 2022

@ShivamBhasin2002 please link this PR to an issue. I believe its #302

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please assign the issue

@ShivamBhasin2002
Copy link
Contributor Author

yeah @koustov #302

@koustov
Copy link
Member

koustov commented Jun 24, 2022

yeah @koustov #302

As of now, I have attached it.

image

image

Just make sure we link it while we are creating the PR

@atapas atapas merged commit 35faa4e into reactplay:main Jun 25, 2022
@atapas
Copy link
Member

atapas commented Jun 25, 2022

@all-contributors please add @ShivamBhasin2002 for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @ShivamBhasin2002! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Filter box appear on landing page of the application
3 participants