Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer enhancements #358

Merged
merged 26 commits into from
Jul 14, 2022
Merged

Footer enhancements #358

merged 26 commits into from
Jul 14, 2022

Conversation

nirmalkc
Copy link
Collaborator

@nirmalkc nirmalkc commented Jun 28, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Current footer is quite simple. Need more additional information about the vision of the project, stack used, purpose, contact options etc.,

Fixes given

  • Footer logo
  • A short description about the owner
  • Social media connecting options
  • Description about the framework
  • What can you do using the framework
  • How can you start with this framework
  • How can you show your support to this framework by a tweet or being a sponsor.

@nirmalkc nirmalkc linked an issue Jun 28, 2022 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Jun 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 5:34AM (UTC)

@nirmalkc nirmalkc self-assigned this Jun 28, 2022
@nirmalkc
Copy link
Collaborator Author

nirmalkc commented Jun 28, 2022

@atapas , need your help in the following areas to get this merged.

  1. Share link integration with the modal.
  2. Sponsor link integration
  3. ID review for all the text
  4. Powered by link integration

@Programming-School-Pro-Coding
Copy link
Contributor

@atapas , need your help in the following areas to get this merged.

  1. Share link integration with the modal.
  2. Sponsor link integration
  3. ID review for all the text
  4. Powered by link integration

You can get the share link to twitter from here: https://twitter.com/intent/tweet?url=https://react-play-a7p3n7z34-atapas.vercel.app/#&text=Learning%20ReactJS%3F%20Check%20out%20this%20awesome%20React%20Playlist!&hashtags=javascript%2Cdevcommunity%2C100daysofcode%2Creact%2Creactplay&via=reactplayIO

Angryman18
Angryman18 previously approved these changes Jul 10, 2022
Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped few comments

src/App.css Show resolved Hide resolved
src/App.css Show resolved Hide resolved
src/common/footer/Footer.jsx Outdated Show resolved Hide resolved
src/common/footer/Footer.jsx Outdated Show resolved Hide resolved
src/common/footer/Footer.jsx Outdated Show resolved Hide resolved
src/common/footer/Footer.jsx Outdated Show resolved Hide resolved
src/common/footer/Footer.jsx Show resolved Hide resolved
src/common/header/HeaderNav.jsx Outdated Show resolved Hide resolved
src/common/techstack/TechStackInfo.js Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented Jul 12, 2022

@koustov could you please finish the review?

koustov
koustov previously approved these changes Jul 13, 2022
Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with conditions

  1. @nirmalkc please create issue to convert the complex CSS files to SCSS
  2. Create another issue if you feel that we should render a small section for tech stack (maybe a categorized one).

@atapas
Copy link
Member

atapas commented Jul 14, 2022

Approving with conditions

  1. @nirmalkc please create issue to convert the complex CSS files to SCSS
  2. Create another issue if you feel that we should render a small section for tech stack (maybe a categorized one).

Approving with conditions

  1. @nirmalkc please create issue to convert the complex CSS files to SCSS
  2. Create another issue if you feel that we should render a small section for tech stack (maybe a categorized one).

I have created an issue for the first one: #374

I'll let @nirmalkc decide on the second. Going ahead with merge.

atapas
atapas previously approved these changes Jul 14, 2022
@nirmalkc
Copy link
Collaborator Author

Approving with conditions

  1. @nirmalkc please create issue to convert the complex CSS files to SCSS
  2. Create another issue if you feel that we should render a small section for tech stack (maybe a categorized one).

Approving with conditions

  1. @nirmalkc please create issue to convert the complex CSS files to SCSS
  2. Create another issue if you feel that we should render a small section for tech stack (maybe a categorized one).

I have created an issue for the first one: #374

I'll let @nirmalkc decide on the second. Going ahead with merge.

I have created a new issue for the tech stack page.
#375

@atapas atapas merged commit 157207c into main Jul 14, 2022
@atapas atapas deleted the 340-bug-report-footer-enhancements branch July 14, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature Request]: Footer enhancements
5 participants