Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding 404 styling #36

Merged
merged 2 commits into from
Apr 18, 2022
Merged

adding 404 styling #36

merged 2 commits into from
Apr 18, 2022

Conversation

nirmalkc
Copy link
Collaborator

Description

404 page has been styled

@nirmalkc nirmalkc added bug Something isn't working review ready labels Apr 17, 2022
@nirmalkc nirmalkc requested a review from atapas April 17, 2022 08:49
@nirmalkc nirmalkc self-assigned this Apr 17, 2022
@nirmalkc nirmalkc linked an issue Apr 17, 2022 that may be closed by this pull request
Create a better 404 page #23
Closed
@vercel
Copy link

vercel bot commented Apr 17, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/H3Uwb4RM13kpFFijFhoAc7NjVV74
✅ Preview: https://react-play-git-23-create-a-better-404-page-atapas.vercel.app

atapas
atapas requested changes Apr 17, 2022
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirmalkc Can we check the color contrast of the link? I think, it can be made better considering the white background

image

@nirmalkc
Copy link
Collaborator Author

@nirmalkc Can we check the color contrast of the link? I think, it can be made better considering the white background

image

image

Hope this works. This is consistent with how we used it in the homepage

atapas
atapas approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@atapas atapas merged commit 21cdac7 into main Apr 18, 2022
@atapas atapas deleted the 23-create-a-better-404-page branch April 18, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas atapas approved these changes

Assignees

@nirmalkc nirmalkc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a better 404 page
2 participants
@nirmalkc @atapas