Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change light logo #381

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Change light logo #381

merged 3 commits into from
Jul 18, 2022

Conversation

6km
Copy link
Member

@6km 6km commented Jul 18, 2022

Description

I have added the play sign to the light logo

Fixes #380

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@6km 6km requested review from atapas and koustov as code owners July 18, 2022 02:35
@vercel
Copy link

vercel bot commented Jul 18, 2022

@6km is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 6:36AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@6km Thanks for noticing it and making the fix.

A quick observation.. The size seems to be smaller after the change. Kindly compare and fix.

@6km
Copy link
Member Author

6km commented Jul 18, 2022

The size seems to be smaller after the change. Kindly compare and fix.

I changed the size, can you re-review please?

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@6km looks good

@atapas atapas merged commit 3585f57 into reactplay:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Dark and light logos are not the same
2 participants