Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shimmer effect #40

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Shimmer effect #40

merged 2 commits into from
Apr 19, 2022

Conversation

abhikhatri67
Copy link

@abhikhatri67 abhikhatri67 commented Apr 17, 2022

Description

Added shimmer effect in play thumbnails images using react-shimmer-effect npm package.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested this on a slow 3g network using chrome dev tools.

Checklist:

  • I have performed a self-review of my own code

@vercel
Copy link

vercel bot commented Apr 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/o8jWiBJgDQKTjA82PrfNTWBR9Sqv
✅ Preview: https://react-play-git-fork-abhikhatri67-shimmer-effect-atapas.vercel.app

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just one change request. Can you please use yarn and commit the yarn lock file instead?

@atapas
Copy link
Member

atapas commented Apr 18, 2022

All good, just one change request. Can you please use yarn and commit the yarn lock file instead?

@abhikhatri67 Not sure if you got a chance to see this comment.

@abhikhatri67
Copy link
Author

All good, just one change request. Can you please use yarn and commit the yarn lock file instead?

@abhikhatri67 Not sure if you got a chance to see this comment.

@atapas Sure will do that.

@abhikhatri67
Copy link
Author

Done @atapas.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@atapas atapas merged commit 126d514 into reactplay:main Apr 19, 2022
@atapas
Copy link
Member

atapas commented Apr 19, 2022

@all-contributors please add @abhishek-gogroup for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @abhishek-gogroup! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add shimmer effect for the play thumbnails
3 participants