Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play state #41

Merged
merged 10 commits into from
Apr 19, 2022
Merged

Play state #41

merged 10 commits into from
Apr 19, 2022

Conversation

Abhishek-90
Copy link
Contributor

@Abhishek-90 Abhishek-90 commented Apr 18, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Apr 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/7dTYYtD9XSHx8ox8BP2LLqNHHEiy
✅ Preview: https://react-play-git-fork-abhishek-90-playstate-atapas.vercel.app

@atapas
Copy link
Member

atapas commented Apr 18, 2022

@Abhishek-90 Could you please create an issue for this play?

@Abhishek-90
Copy link
Contributor Author

@atapas, Issue Created Issue Link

@atapas atapas linked an issue Apr 18, 2022 that may be closed by this pull request
@Abhishek-90
Copy link
Contributor Author

#44

@atapas atapas self-requested a review April 18, 2022 12:32
src/meta/play-meta.js Show resolved Hide resolved
src/plays/index.js Show resolved Hide resolved
src/plays/states/States.jsx Show resolved Hide resolved
src/plays/states/States.jsx Outdated Show resolved Hide resolved
src/plays/states/States.jsx Outdated Show resolved Hide resolved
src/plays/states/States.jsx Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented Apr 18, 2022

Also build fails due to wrong reference of CSS file. You can run yarn build locally. @Abhishek-90

src/plays/states/States.jsx Show resolved Hide resolved
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishek-90 Changes are looking good now. Could you please pull the updates from main once more and notify me for merge? Also make sure, there is no warning in the console.

@Abhishek-90
Copy link
Contributor Author

@atapas can't pull new updates from your main as there are updates on my end as well. I guess first you need to merge then I can get the combined changes

@atapas
Copy link
Member

atapas commented Apr 19, 2022

@atapas can't pull new updates from your main as there are updates on my end as well. I guess first you need to merge then I can get the combined changes

Oh no @Abhishek-90 you can still merge in.. like from the atapas:main to your branch and then resolve if any conflicts. But as the PR is not showing any conflicts, I guess it is safe to merge.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@atapas atapas merged commit 96b1529 into reactplay:main Apr 19, 2022
@atapas
Copy link
Member

atapas commented Apr 19, 2022

@all-contributors please add @Abhishek-90 for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @Abhishek-90! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: State of Component
2 participants