-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play state #41
Play state #41
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/atapas/react-play/7dTYYtD9XSHx8ox8BP2LLqNHHEiy |
@Abhishek-90 Could you please create an issue for this play? |
@atapas, Issue Created Issue Link |
Also build fails due to wrong reference of CSS file. You can run yarn build locally. @Abhishek-90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhishek-90 Changes are looking good now. Could you please pull the updates from main once more and notify me for merge? Also make sure, there is no warning in the console.
@atapas can't pull new updates from your main as there are updates on my end as well. I guess first you need to merge then I can get the combined changes |
Oh no @Abhishek-90 you can still merge in.. like from the atapas:main to your branch and then resolve if any conflicts. But as the PR is not showing any conflicts, I guess it is safe to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@all-contributors please add @Abhishek-90 for Code |
I've put up a pull request to add @Abhishek-90! 🎉 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: