Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new play - [random meme generator] #45

Merged
merged 6 commits into from
Apr 18, 2022
Merged

add a new play - [random meme generator] #45

merged 6 commits into from
Apr 18, 2022

Conversation

murtuzaalisurti
Copy link
Member

@murtuzaalisurti murtuzaalisurti commented Apr 18, 2022

Description

A project to demonstrate the use of API to fetch random memes!

Type of change

New Play Added

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Apr 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/J25THW9khRkdrrNLWAk6yoNNdUXM
✅ Preview: https://react-play-git-fork-murtuzaalisurti-main-atapas.vercel.app

@atapas
Copy link
Member

atapas commented Apr 18, 2022

One request, @murtuzaalisurti

For your play, can you please drop a readme like this one? It may help beginners to connect to the code faster:

https://github.com/atapas/react-play/blob/main/src/plays/social-card/Readme.md

Also, when it is ready to review, please tag me.

@murtuzaalisurti
Copy link
Member Author

@atapas readme added

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a cover by creating any relevant cover.png and drop it in your play folder. That will be great. Let me know if you need help.

@murtuzaalisurti
Copy link
Member Author

You can add a cover by creating any relevant cover.png and drop it in your play folder. That will be great. Let me know if you need help.

done ✨

public/index.html Outdated Show resolved Hide resolved
src/plays/random-meme-generator/RandomMemeGenerator.jsx Outdated Show resolved Hide resolved
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtuzaalisurti Changes are looking good.

@atapas atapas merged commit 932d103 into reactplay:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a play]: Random meme generator
2 participants