Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flickering in expanding card fixed #452

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

Deepak8717
Copy link
Member

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

There was flickering when click on the card. Transition wasn't smooth.

Fixes #451

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@vercel
Copy link

vercel bot commented Aug 4, 2022

@Deepak8717 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 0:26AM (UTC)

@atapas atapas merged commit b915a42 into reactplay:main Aug 4, 2022
@Deepak8717 Deepak8717 deleted the bug/expanding-card branch August 4, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Flickring with expanding card play
2 participants