Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Play - React Gradients #466

Merged
merged 34 commits into from
Aug 10, 2022
Merged

Added New Play - React Gradients #466

merged 34 commits into from
Aug 10, 2022

Conversation

ammaaraslam
Copy link
Member

Description

This is a new play consisting of a collection of beautiful gradients that can be copied either as TailwindCSS or CSS code and use in their application. Users are also able to copy each color used in a gradient. This play uses TailwindCSS for styling and one third-part library, react-hot-toast for notifications(toasts).

Please Note:- I have used inline CSS in one place to style one thing in the entire play. I've used it for dynamically adding a gradient background to a div. I couldn't quite get it to work with TailwindCSS.

Fixes #442

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This play has been tested on my local machine. It creates no new errors and passes all unit tests.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Aug 7, 2022

@ammaaraslam is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 4:17AM (UTC)

@ammaaraslam
Copy link
Member Author

Hi @atapas. I'll try to fix the changes that you implied. I'll get back with the changes soon!

@ammaaraslam
Copy link
Member Author

Hey @atapas. I have made changes to the play according to your suggestions. Combining the three copy functions into one is a very efficient and a good practice. I didn't think of that when developing, so thanks for pointing that out.
And if you need any other changes to be made, let me know. I'm happy to work with you in this project.

atapas
atapas previously approved these changes Aug 9, 2022
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atapas
Copy link
Member

atapas commented Aug 9, 2022

@koustov I am good with the changes. Please merge if it looks good to you.

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of suggestions

src/plays/react-gradients/GradientComponent.js Outdated Show resolved Hide resolved
src/plays/react-gradients/ReactGradients.js Outdated Show resolved Hide resolved
@koustov
Copy link
Member

koustov commented Aug 9, 2022

@ammaaraslam , the UI is very simple yet elegant.

@ammaaraslam
Copy link
Member Author

ammaaraslam commented Aug 9, 2022

Hi @koustov. I'll make the necessary changes you suggested and get back to you soon.

@ammaaraslam
Copy link
Member Author

Hey @koustov, I have made the suggested changes. If there's any more changes that need to be made, let me know.

@atapas
Copy link
Member

atapas commented Aug 10, 2022

@koustov you can close this one.

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koustov koustov merged commit 10ae2fc into reactplay:main Aug 10, 2022
@atapas
Copy link
Member

atapas commented Aug 14, 2022

@all-contributors please add @ammaaraslam for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @ammaaraslam! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: React Gradients
3 participants