Fix 🐛 Bug #443 : Play snap is broken: Cover image is not appearing

[Sachin-chaurasiya]

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I worked on fixing bug #443, Cover Image is not showing up when there is no cover image for the play in the database.
The fix will work like this,
If the cover is in DB then it will be shown, otherwise, we will look for the cover image in the play folder and if that is available it will be shown else default cover will be shown.

Fixes #443

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

1. Go to Any play
2. Copy the Play URL
3. Now share the Play URL
4. And see the preview cover

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-play	✅ Ready (Inspect)	Visit Preview	Aug 14, 2022 at 7:17PM (UTC)

[Sachin-chaurasiya]

@atapas @koustov, PR is ready for review.

[koustov]

Looks good to me. @atapas can you make this build snap enabled to that we can test.

[atapas]

Looks good to me. @atapas can you make this build snap enabled to that we can test.

It's already enabled

[atapas]

Looks good to me. @atapas can you make this build snap enabled to that we can test.

It's already enabled

@Sachin-chaurasiya did you have any success with the test? Codewise, I see all set actually. But when I tested it last time, the image was not showing up. Let's fix it/discuss.

cc: @koustov @Angryman18 please chime in with your ideas.

[Sachin-chaurasiya]

Looks good to me. @atapas can you make this build snap enabled to that we can test.

It's already enabled

@Sachin-chaurasiya did you have any success with the test? Codewise, I see all set actually. But when I tested it last time, the image was not showing up. Let's fix it/discuss.

cc: @koustov @Angryman18 please chime in with your ideas.

Hey @atapas , No success, I tried a few other options too but no luck...

[koustov]

@Sachin-chaurasiya @atapas, I think I have fixed it. I will check in to this branch instead of a new one.

[Sachin-chaurasiya]

@Sachin-chaurasiya @atapas, I think I have fixed it. I will check in to this branch instead of a new one.

Yeah @koustov, Please go ahead.

[atapas]

LGTM

@koustov do a final review and merge plz.

[koustov]

@atapas we have some issues with vercel. It builds the meta tag with localhost. I have now modified the PR to work on the prod build NOT the preview build as a stop-gap measurement.
Can you get it merged, and then we can run one round of verification on the prod

[koustov]

@atapas we have some issues with vercel. It builds the meta tag with localhost. I have now modified the PR to work on the prod build NOT the preview build as a stop-gap measurement. Can you get it merged, and then we can run one round of verification on the prod

[koustov]

lgtm

[Sachin-chaurasiya]

@atapas , awaiting for your approval.