-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add star rating play #513
add star rating play #513
Conversation
This fixes issue reactplay#464
@frankiefab100 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few early impression
- Unwanted vertical and horizontal; scrollbar appearing
- It would be great if you can associate some titles with each start. something like "Bad", "Not OK", "Good", "Very Good", "Spelbound"
- it would be even better if you can give me some options to choose from. Like you have already implemented with
star
, probably another option would besmilies
and so on
No 1 is mandatory to fix whereas No 2 and No 3, I would leave with you.
Once done I can start reviewing.
Alright |
Hey @frankiefab100 , let us know when its ready |
Hi @koustov I have made the necessary changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments dropped
@frankiefab100 let's close this one soon and get in. |
I pushed new commits yesterday. Waiting for a review |
Ok @koustov will close it then tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comment. Once implemented, its ready to merge
src/plays/star-rating/styles.css
Outdated
width: 100vw; | ||
height: 100vh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100vh and 100vw are creating scroll to the container.
Replace the height and width with
height: 100%
width: 100%
It will solve the scroll issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks.
I wonder why it looks okay from my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fabulous job @frankiefab100
Thank you 😄 |
This fixes issue #464
Description
A
Star rating
play shows the use of useState hookFixes #464
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally on localhost
Checklist: