Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: grammatical errors fixed #573

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Conversation

KashishLakhara04
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This para in readme.md file is updated..
It will open the cypress dashboard, through which you need to select E2E Testing. Once you are done with the selection you will get options to choose your preferred browser in which you want to run the test.! Once you are done selecting the browser you need to click on Start E2E Testing in <SELECTED_BROWSER_NAME>. Selected browser will popup and you can able to see a list of cypress tests, click on the test to start testing.!

Fixes #571

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Sep 28, 2022

@KashishLakhara04 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 5:50PM (UTC)

README.md Outdated Show resolved Hide resolved
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested change!

@KashishLakhara04
Copy link
Contributor Author

made the suggested changes.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KashishLakhara04 Thank you for making it better.

@koustov koustov added the hacktoberfest-accepted hacktoberfest-accepted label Oct 9, 2022
Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koustov koustov merged commit fd826f6 into reactplay:main Oct 9, 2022
@koustov
Copy link
Member

koustov commented Oct 9, 2022

@all-contributors please add @KashishLakhara04 for Code

@allcontributors
Copy link
Contributor

@koustov

I've put up a pull request to add @KashishLakhara04! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Some grammatical mistakes
4 participants