Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: feature that will create new readme file for each play at the time of creating play #58

Merged
merged 7 commits into from
Apr 19, 2022
Merged

Conversation

hasnainmakada-99
Copy link
Contributor

@hasnainmakada-99 hasnainmakada-99 commented Apr 19, 2022

Description

Added a new file in the plop-templates which will define the heading of the readme of each play

Fixes #(47)

Type of change

Added Feature

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

yarn create-play by creating a sample play (Deleted it afterwards)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Apr 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/2CMTj9pNFRAXcMudFpkvrBoPVPqW
✅ Preview: https://react-play-git-fork-hasnainmakada-99-hasnain-atapas.vercel.app

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only files you should be committing is play-readme.hbs and plopfile.js

src/meta/play-meta.js Outdated Show resolved Hide resolved
src/meta/play-meta.js Outdated Show resolved Hide resolved
src/plays/index.js Outdated Show resolved Hide resolved
@hasnainmakada-99
Copy link
Contributor Author

Tapas sir i've made the changes which you gave me

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@atapas atapas merged commit c49dd4f into reactplay:main Apr 19, 2022
@atapas atapas linked an issue Apr 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Generate a Readme.md file for each play
2 participants