Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plays route failture #68

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Fix plays route failture #68

merged 3 commits into from
Apr 19, 2022

Conversation

6km
Copy link
Member

@6km 6km commented Apr 19, 2022

Description

I've fixed the error that shows when you open a 'play' link by passing the state to the component itself

Fixes #66

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  1. Open your browser
  2. Paste this URL: https://react-play-git-fork-6km-main-atapas.vercel.app/plays/social-card and hit enter

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Apr 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/2bPDQ8viLdnRSeiZ4YkHnyE8vKbh
✅ Preview: https://react-play-git-fork-6km-main-atapas.vercel.app

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@6km Great, thanks for adding the fix for 8 existing plays. There is one more place the fix is required.

We generate the play files using the PlopJS template for any new play. So you need to update the template according to this fix. The template file is: https://github.com/atapas/react-play/blob/main/plop-templates/component.hbs

Once updated, please try the yarn create-play command to create a sample play and test that locally for routing and basic sanity. Please do not commit the files generated out of the sample play test. Thanks a ton.

@6km
Copy link
Member Author

6km commented Apr 19, 2022

@atapas can you review the PR again?

@atapas
Copy link
Member

atapas commented Apr 19, 2022

@atapas can you review the PR again?

Can you please confirm that you have created the new play creation workflow in the UI and tested the routing fix with a new play?

I can test it as well if you haven't done already.

@6km
Copy link
Member Author

6km commented Apr 19, 2022

@atapas I've tested the new play creation workflow and everything is okay.
image

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@6km looks good.

@atapas atapas self-requested a review April 19, 2022 17:21
@atapas atapas merged commit c6cde56 into reactplay:main Apr 19, 2022
@6km
Copy link
Member Author

6km commented Apr 19, 2022

@atapas Thanks for approving my changes

@atapas
Copy link
Member

atapas commented Apr 19, 2022

@all-contributors please add @6km for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @6km! 🎉

@atapas
Copy link
Member

atapas commented Apr 19, 2022

@atapas Thanks for approving my changes

Thanks for fixing it and the Twitter link too. In case you share your experience on Twitter, don't forget tag ReactPlayIO 💚.

Keep contributing. @6km

@6km
Copy link
Member Author

6km commented Apr 19, 2022

@atapas You're welcome. all of your projects are awesome 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Deep Linking for the Plays fails. It shows a blank page.
2 participants