-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plays route failture #68
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/atapas/react-play/2bPDQ8viLdnRSeiZ4YkHnyE8vKbh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@6km Great, thanks for adding the fix for 8 existing plays. There is one more place the fix is required.
We generate the play files using the PlopJS template for any new play. So you need to update the template according to this fix. The template file is: https://github.com/atapas/react-play/blob/main/plop-templates/component.hbs
Once updated, please try the yarn create-play
command to create a sample play and test that locally for routing and basic sanity. Please do not commit the files generated out of the sample play test. Thanks a ton.
@atapas can you review the PR again? |
Can you please confirm that you have created the new play creation workflow in the UI and tested the routing fix with a new play? I can test it as well if you haven't done already. |
@atapas I've tested the new play creation workflow and everything is okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@6km looks good.
@atapas Thanks for approving my changes |
@all-contributors please add @6km for Code |
I've put up a pull request to add @6km! 🎉 |
@atapas You're welcome. all of your projects are awesome 😉. |
Description
I've fixed the error that shows when you open a 'play' link by passing the state to the component itself
Fixes #66
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: