Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text underline moved to the back #744

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Text underline moved to the back #744

merged 1 commit into from
Oct 27, 2022

Conversation

Hat52
Copy link
Contributor

@Hat52 Hat52 commented Oct 21, 2022

Description

The underline was hiding the text behind. Now it is moved to the back of the text. closes #703

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have tested the changes by running them on my local.

Checklist:

  • I have performed a self-review of my own code

@vercel
Copy link

vercel bot commented Oct 21, 2022

@Hat52 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@Hat52 Hat52 closed this Oct 21, 2022
@Hat52 Hat52 reopened this Oct 21, 2022
@Sachin-chaurasiya
Copy link
Member

@Hat52 , Can you add the proper title for the PR?

@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 11:29AM (UTC)

@Hat52 Hat52 changed the title Pull request for #703 Text underline moved to the back Oct 25, 2022
@Hat52
Copy link
Contributor Author

Hat52 commented Oct 25, 2022

@Sachin-chaurasiya Done

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed.

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 27, 2022
@atapas atapas merged commit 3884c0b into reactplay:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Design Fix]: The line under the text hide the text
3 participants