Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Web3 Staking Dapp #767

Merged
merged 16 commits into from
Oct 30, 2022
Merged

Added Web3 Staking Dapp #767

merged 16 commits into from
Oct 30, 2022

Conversation

nirban256
Copy link
Contributor

Description

It is a Staking Dapp where people will get interest based on the amount they stake after a specific period of time. I have added some dependencies namely hardhat and ethers in order to build the Dapp (Decentralized Application).

Fixes #550

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 28, 2022

@nirban256 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@nirban256
Copy link
Contributor Author

@atapas pls review the pr

@vercel
Copy link

vercel bot commented Oct 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 3:48PM (UTC)

atapas
atapas requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given some initial comments.

@Sachin-chaurasiya will do deep review.

src/plays/web3-staking-dapp/artifacts/build-info/5faf9c6c2f8753632f3c7c13937cd196.json Show resolved Hide resolved
src/plays/web3-staking-dapp/artifacts/contracts/Staking.sol/Staking.dbg.json Show resolved Hide resolved
src/plays/web3-staking-dapp/styles.css Outdated Show resolved Hide resolved
Sachin-chaurasiya
Sachin-chaurasiya requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

src/plays/web3-staking-dapp/Readme.md Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/Web3StakingDapp.js Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/Web3StakingDapp.js Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/Web3StakingDapp.js Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/Web3StakingDapp.js Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/smart-contract/cache/solidity-files-cache.json Outdated Show resolved Hide resolved
@nirban256
Copy link
Contributor Author

If all the conditions are met then please merge the pr

Sachin-chaurasiya
Sachin-chaurasiya requested changes Oct 30, 2022
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirban256 Few more comments and remove the src/plays/web3-staking-dapp/styles.css as it's empty.

src/plays/web3-staking-dapp/components/Navbar.js Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/smart-contract/cache/solidity-files-cache.json Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/smart-contract/scripts/deploy.js Outdated Show resolved Hide resolved
src/plays/web3-staking-dapp/smart-contract/scripts/deploy.js Outdated Show resolved Hide resolved
@Sachin-chaurasiya
Copy link
Member

Sachin-chaurasiya commented Oct 30, 2022 •
edited
Loading

@nirban256 , Build is failing, As we have deleted the styles.css and we have to remove the reference of it as well.

image

@nirban256
Copy link
Contributor Author

@nirban256 , Build is failing, As we have deleted the styles.css and we have to remove the reference of it as well.

image

removed the line @Sachin-chaurasiya

Sachin-chaurasiya
Sachin-chaurasiya approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nirban256

@nirban256
Copy link
Contributor Author

thanks @Sachin-chaurasiya

@nirban256 nirban256 requested a review from atapas October 30, 2022 15:59
atapas
atapas approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@atapas atapas added hacktoberfest-accepted hacktoberfest-accepted and removed waiting for reviewers labels Oct 30, 2022
@atapas atapas merged commit 2d47b55 into reactplay:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas atapas approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@koustov koustov Awaiting requested review from koustov

Assignees

@nirban256 nirban256

Labels
hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Web3 Staking Dap
3 participants
@nirban256 @Sachin-chaurasiya @atapas