Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plays responsiveness #772

Merged
merged 4 commits into from
Oct 30, 2022
Merged

Plays responsiveness #772

merged 4 commits into from
Oct 30, 2022

Conversation

yung-coder
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

I tried to fix the responsiveness of the recently added plays (download fetch response and multi select component)

Fixes #760

Type of change

  • [✅ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It has been tested by me in my local system for all the edge cases.

Checklist:

  • [✅ ] I have performed a self-review of my own code
  • [✅] I have commented my code, particularly in hard-to-understand areas
  • [✅ ] I have made corresponding changes to the documentation
  • [✅] My changes generate no new warnings
  • ✅] I have added tests that prove my fix is effective or that my feature works
  • [✅] New and existing unit tests pass locally with my changes
  • [✅ ] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

last-issue1

last-issue2

@vercel
Copy link

vercel bot commented Oct 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 2:25PM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good.

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 30, 2022
@atapas atapas merged commit c6a28f8 into main Oct 30, 2022
@atapas atapas deleted the plays-responsiveness branch October 30, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: New plays lack responsiveness
2 participants