Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-783 removed key config from web3 play #789

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Conversation

koustov
Copy link
Member

@koustov koustov commented Nov 11, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

In headless browsing, window values will be undefined. Hence the snap is failing. As a fix, I have just added a try/catch which will allow snap but wont affect actual build

Fixes #783

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@koustov koustov requested a review from atapas as a code owner November 11, 2022 05:10
@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 5:46AM (UTC)

@koustov koustov marked this pull request as ready for review November 11, 2022 05:44
@atapas atapas merged commit 0d064cc into main Nov 11, 2022
@atapas atapas deleted the Issue-783-snap-failure branch November 11, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: The main build fails when snap is enabled
3 participants