Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Issue #818] Display text 'All' in creator filter when selected #820

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: [Issue #818] Display text 'All' in creator filter when selected #820

merged 1 commit into from
Nov 29, 2022

Conversation

supminn
Copy link
Contributor

@supminn supminn commented Nov 28, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@netlify
Copy link

netlify bot commented Nov 28, 2022

‼️ Deploy request for reactplayio rejected.

Name Link
🔨 Latest commit 0c6afa1

@vercel
Copy link

vercel bot commented Nov 28, 2022

@supminn is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@supminn
Copy link
Contributor Author

supminn commented Nov 28, 2022

Hi @atapas
This was a quick fix. Could you review the PR, please?

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 10:02AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looking good.

@atapas atapas merged commit acf475d into reactplay:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants