Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to 404 Page - working #848

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Redirect to 404 Page - working #848

merged 5 commits into from
Jan 4, 2023

Conversation

AbhiPatel10
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

When we entered anything in the route path, there was no 404 page, so I added one to the routing. 

Fixes #847

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Type anything in Route path like http://localhost:3000/playssdd.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

AbhiPatel10 and others added 4 commits December 22, 2022 12:31
It's Roll dice game Where all Dice should be same, Click each die to freeze it at its current value between rolls.
…Update] Style Class name

I have added all about my game tenzies into readme file, also add Implementation on it.

Style class name changed.
@vercel
Copy link

vercel bot commented Dec 25, 2022

@AbhiPatel10 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@AbhiPatel10
Copy link
Contributor Author

@atapas sir and @koustov bro Please check this PR.

@atapas
Copy link
Member

atapas commented Dec 27, 2022

@atapas sir and @koustov bro Please check this PR.

As I'm on vacation,it may take a bit longer. Will check soon.

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 6:13AM (UTC)

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koustov
Copy link
Member

koustov commented Jan 4, 2023

The 404 page still has some issues. I am not holding this PR for those issues, create a new one on #855

@koustov koustov merged commit 18f9c2c into reactplay:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Not Redirect to 404 Page
3 participants