Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Comments and Reactions for the Plays #85

Merged
merged 24 commits into from
May 6, 2022

Conversation

atapas
Copy link
Member

@atapas atapas commented Apr 21, 2022

Description

Enabling the reactions and comments using Giscus for the plays.

Fixes # (issue) #67

Type of change

We need to include the Giscus integration with the GitHub repo secrets. The secrets to be read from the .env file.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@atapas atapas added the work in progress The work is in progress label Apr 21, 2022
@atapas atapas self-assigned this Apr 21, 2022
@vercel
Copy link

vercel bot commented Apr 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/2HEV17dsfoQKaSkaS8dN1gNzaGeV
✅ Preview: https://react-play-git-issue-67-like-comment-play-atapas.vercel.app

@atapas
Copy link
Member Author

atapas commented Apr 21, 2022

Hello @atapas @nirmalkc

We have upgraded to React v18 as part of this issue: #87

We have tested the existing plays. All good. Please pull this change to your branch and keep it up-to-date. You have to do sanity of things to make sure everything works for your changes in your branch.

Happy Coding!

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 6, 2022 at 6:28AM (UTC)

@atapas atapas merged commit 32868cb into main May 6, 2022
@atapas atapas deleted the issue-67-like-comment-play branch May 6, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress The work is in progress
Projects
None yet
2 participants