Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created the banner structure and fixed the styling #877

Merged
merged 11 commits into from
Jan 24, 2023
Merged

Created the banner structure and fixed the styling #877

merged 11 commits into from
Jan 24, 2023

Conversation

aimun-naharr
Copy link
Contributor

@aimun-naharr aimun-naharr commented Jan 16, 2023 •
edited
Loading

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added a dynamic banner which will change everytime the page loads

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code

Screenshots or example output

image

@vercel
Copy link

vercel bot commented Jan 17, 2023

@aimunhidden485 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@aimun-naharr aimun-naharr changed the title [WIP] Created the banner structure and fixed the styling Created the banner structure and fixed the styling Jan 17, 2023
@vercel
Copy link

vercel bot commented Jan 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 24, 2023 at 6:50AM (UTC)

@atapas
Copy link
Member

atapas commented Jan 17, 2023

@aimunhidden485 The build fails with a lot of lint errors

image

Please follow the steps in readme to correct those.

@aimun-naharr
Copy link
Contributor Author

@aimunhidden485 The build fails with a lot of lint errors

image

Please follow the steps in readme to correct those.

okay I'm checking

atapas
atapas requested changes Jan 18, 2023
View reviewed changes
src/common/playlists/DynamicBanner.jsx Outdated Show resolved Hide resolved
src/common/playlists/PlayList.jsx Show resolved Hide resolved
@atapas
Copy link
Member

atapas commented Jan 18, 2023

Sometime getting preview not available even of there is a cover image

image

@aimun-naharr
Copy link
Contributor Author

Sometime getting preview not available even of there is a cover image

image

Okay I'm checking

@aimun-naharr
Copy link
Contributor Author

ReactPlay.-.Plays.1.mp4

atapas
atapas previously approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with @koustov and it worked well.

@atapas atapas linked an issue Jan 24, 2023 that may be closed by this pull request
✨ [Feature request]: Add banner feature to playlist page #873
Closed
1 task
@atapas
Copy link
Member

atapas commented Jan 24, 2023 •
edited
Loading

Hi @aimunhidden485 Do not truncate the description here?

image

Can you please fix this so that I can merge?

@aimun-naharr
Copy link
Contributor Author

Hi @aimunhidden485 Do not truncate the description here?

image

Can you please fix this so that I can merge?

sure

@atapas atapas merged commit d6ea3d1 into reactplay:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas atapas approved these changes

@koustov koustov Awaiting requested review from koustov

Assignees

@aimun-naharr aimun-naharr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Add banner feature to playlist page
2 participants
@aimun-naharr @atapas