Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2PlaysAMonth]: Calculator #944

Merged
merged 13 commits into from
Feb 27, 2023
Merged

[#2PlaysAMonth]: Calculator #944

merged 13 commits into from
Feb 27, 2023

Conversation

suryanshsoni120
Copy link
Contributor

Description

A Calculator which can perform basic arithmetic operations.

Fixes #928

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on local system.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@vercel
Copy link

vercel bot commented Feb 6, 2023

@suryanshsoni120 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.
Stale Marking : After 30 days of inactivity this PR will be marked as stale PR and it will be closed and locked in 7 days if no further activity occurs.

@suryanshsoni120 suryanshsoni120 changed the title Created calculator [#2PlaysAMonth]: Calculator Feb 6, 2023
@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 4:27AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey great work! Please take care of the review comments to get t merged.

src/plays/simple-calculator/Readme.md Show resolved Hide resolved
src/plays/simple-calculator/Readme.md Outdated Show resolved Hide resolved
src/plays/simple-calculator/SimpleCalculator.js Outdated Show resolved Hide resolved
src/plays/simple-calculator/styles/Buttons.css Outdated Show resolved Hide resolved
src/plays/simple-calculator/styles/Calculator.css Outdated Show resolved Hide resolved
src/plays/simple-calculator/styles/Display.css Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit 47eef5d
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/63eb6a0954c31700085c922e

@atapas
Copy link
Member

atapas commented Feb 14, 2023

Hi @suryanshsoni120 Please catch me on discord as I still see the review comments opened about the style override. I can explain to you over a quick call.

@atapas
Copy link
Member

atapas commented Feb 17, 2023

@suryanshsoni120 Please add the video link

@atapas
Copy link
Member

atapas commented Feb 18, 2023

@suryanshsoni120 Please add the video link

@suryanshsoni120 any update?

@atapas
Copy link
Member

atapas commented Feb 25, 2023

@suryanshsoni120 Please add the video link

@suryanshsoni120 any update?

@suryanshsoni120 will you please add the recording? Your good work will get merged.

@atapas
Copy link
Member

atapas commented Feb 27, 2023

@suryanshsoni120 I am merging your play. But it is still missing the video recording. Please update the video link before 28th Feb 2023 end of the day for it to be qualified for the event.

@atapas atapas merged commit c3d1b42 into reactplay:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[#2PlaysAMonth]: Calculator
2 participants