Update Twitter meta tags #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/atapas/react-play/8jTzZU4RBpmXxnykV885WURhuS6p |
atapas
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the DefMeta component to include the necessary tags for Twitter to display embeds properly. Previously, while we had the twitter:image meta tag set correctly, it didn't have the other necessary meta tags (such as twitter:card etc.) as DefMeta wasn't updating them properly.
The embeds now look like this:
Fixes #95
Type of change
How Has This Been Tested?
Had to test the new changes using an extension again as theres no real other way to test them, but can confirm that everything works as intended so far!
Checklist: