Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2PlaysAmonth] Text analyzer #980

Merged
merged 33 commits into from
Feb 28, 2023
Merged

[#2PlaysAmonth] Text analyzer #980

merged 33 commits into from
Feb 28, 2023

Conversation

yung-coder
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

A Text-Analyzer where you will be able to analyze your text and make it more effective with features like text extraction from image and a lot more.

Fixes #924

How Has This Been Tested ?

It has been tested by me in my local environment

Checklist:

  • [✅] I have performed a self-review of my own code
  • [✅] I have commented my code, particularly in hard-to-understand areas
  • [✅] I have made corresponding changes to the documentation
  • [✅] My changes generate no new warnings
  • [✅] I have added tests that prove my fix is effective or that my feature works
  • [✅] New and existing unit tests pass locally with my changes
  • [✅] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

none

@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 4:55PM (UTC)

@atapas atapas changed the title Text analyzer [#2PlaysAmonth] Text analyzer Feb 18, 2023
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yung-coder Review comment...

also please don;t forget to record a demo on stackstream and add to your play by editing it.

src/plays/text-analyzer/styles/Button.css Outdated Show resolved Hide resolved
@yung-coder
Copy link
Contributor Author

@atapas made the changes

@yung-coder
Copy link
Contributor Author

Hey @atapas is it all good or need to make some changes ..?

@atapas
Copy link
Member

atapas commented Feb 23, 2023

@yung-coder Hello.. Your PR is also merge ready, but missing the link to the recorded demo. Please add it by editing the play so that we can merge it.

@yung-coder
Copy link
Contributor Author

@yung-coder Hello.. Your PR is also merge ready, but missing the link to the recorded demo. Please add it by editing the play so that we can merge it.

Sure will do it asap

@atapas
Copy link
Member

atapas commented Feb 26, 2023

Visit Preview

@yung-coder Can you please take care asap?

@yung-coder
Copy link
Contributor Author

Visit Preview

@yung-coder Can you please take care asap?

@atapas Sorry for the delay, made the changes added videos to both of my plays i think one is without audio if so i will make it again ...

@atapas
Copy link
Member

atapas commented Feb 27, 2023

Visit Preview

@yung-coder Can you please take care asap?

@atapas Sorry for the delay, made the changes added videos to both of my plays i think one is without audio if so i will make it again ...

Where @yung-coder ? I do not see the video added..

image

Please edit the play and add.. Need to merge this.

@yung-coder
Copy link
Contributor Author

Visit Preview

@yung-coder Can you please take care asap?

@atapas Sorry for the delay, made the changes added videos to both of my plays i think one is without audio if so i will make it again ...

Where @yung-coder ? I do not see the video added..

image

Please edit the play and add.. Need to merge this.

@atapas made the changes added video links for both the plays please check it out...

@atapas atapas merged commit 8da750f into main Feb 28, 2023
@atapas atapas deleted the text-analyzer branch February 28, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[#2PlaysAMonth]: Text Analyzer
2 participants