fix(CardTitle,CardSubtitle): div as default tag (#1298)

Closes #1297
reactstrap · Nov 16, 2018 · ea0f1f0 · ea0f1f0
1 parent b45907b
commit ea0f1f0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/src/CardSubtitle.js b/src/CardSubtitle.js
@@ -10,7 +10,7 @@ const propTypes = {
 };
 
 const defaultProps = {
-  tag: 'h6'
+  tag: 'div'
 };
 
 const CardSubtitle = (props) => {

diff --git a/src/CardTitle.js b/src/CardTitle.js
@@ -10,7 +10,7 @@ const propTypes = {
 };
 
 const defaultProps = {
-  tag: 'h5'
+  tag: 'div'
 };
 
 const CardTitle = (props) => {

diff --git a/src/__tests__/CardSubtitle.spec.js b/src/__tests__/CardSubtitle.spec.js
@@ -24,4 +24,10 @@ describe('CardSubtitle', () => {
     expect(wrapper.hasClass('card-subtitle')).toBe(true);
     expect(wrapper.find('h3').length).toBe(1);
   });
+
+  it('should render a "div" tag by default', () => {
+    const wrapper = shallow(<CardSubtitle>Yo!</CardSubtitle>);
+
+    expect(wrapper.find('div').length).toBe(1);
+  });
 });
diff --git a/src/__tests__/CardTitle.spec.js b/src/__tests__/CardTitle.spec.js
@@ -25,9 +25,9 @@ describe('CardTitle', () => {
     expect(wrapper.find('h1').length).toBe(1);
   });
 
-  it('should render a "h5" tag by default', () => {
+  it('should render a "div" tag by default', () => {
     const wrapper = shallow(<CardTitle>Yo!</CardTitle>);
 
-    expect(wrapper.find('h5').length).toBe(1);
+    expect(wrapper.find('div').length).toBe(1);
   });
 });