-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(Modal): unmounting nested modals (#321)
Unmounting nested modals should remove the matching number of `modal-open` classes from the body node. Previously, the updated class names were computed before its children are unmounted and only updated in the DOM afterwards. This can cause `modal-open` class name to be left on the body if any of its children is also a modal (which is also trying to remove those `modal-open` classes).
- Loading branch information
1 parent
5e98ea3
commit ecf51b2
Showing
2 changed files
with
32 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters