Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): closes when dragging outside modal #1047

Conversation

wwwouter
Copy link
Contributor

@wwwouter wwwouter commented May 29, 2018

Modal dialog closes when mouse button is pressed over the dialog window but released outside the window.

See angular-ui/bootstrap#5810 for video. Pull request is based on code changes made in that project.

@wwwouter wwwouter changed the title Fix: Modal closes when dragging outside modal fix(Modal): closes when dragging outside modal May 29, 2018
Copy link
Member

@TheSharpieOne TheSharpieOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheSharpieOne TheSharpieOne merged commit cccd7af into reactstrap:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants