Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): prevent scrollbar from closing (#1097) #1165

Merged
merged 1 commit into from Aug 6, 2018
Merged

fix(Modal): prevent scrollbar from closing (#1097) #1165

merged 1 commit into from Aug 6, 2018

Conversation

nykula
Copy link
Contributor

@nykula nykula commented Aug 6, 2018

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Kept the initial click element reference being saved on mouseDown #1047, that prevents closing while user is selecting text and accidentally moves cursor outside modal. But changed mouseUp back to click, which doesn't fire on scrollbar press, so that user can scroll long modals again.

Fixes #1097.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal closes on scrollbar click
2 participants