-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modals use unsafe lifecycle methods #1159
Comments
The offending usage is here: Lines 116 to 126 in 07ec4b5
React docs on migrating: |
I think this was fixed by c844ab1. |
Related to reactjs/react-transition-group#429 |
https://github.com/reactjs/react-transition-group/blob/master/src/Transition.js#L213 |
any updates? |
Any updates? |
This is fixed in v8. |
I am still seeing the error. To replicate, wrap a Modal in
react v16.13.1 On digging, this is an open issue in react-transition-group reactjs/react-transition-group#429 |
According to this, seems like the issue has been resolved. But weirdly enough, when I installed manually updating the any idea what else can I do? Thanks in advance! |
@aqeebimtiaz I'm not sure if I'll be doing a PR, kind of busy, but I took a jab at it. The issue is you have to add So I tried it and it worked but the issue now is, if you don't pass a ref it will again throw that error, so So inside
|
Hi, Thanks for the fast reply, I tried to use your suggestions & follow this documentation. Unfortunately, nothing worked. |
You have to pass an innerRef, if you don't pass it, it'll throw an error. So if you put something like
before the return |
Should it be reopened? I see the same issue with the following deps in my
|
Still getting the warning in reactstrap 8.9.0 |
experiencing the same error in "reactstrap": "^8.10.1", |
Modal
#6.3.1
umd
#16.4.1
#4.0.0
What is happening?
When displaying a Modal in React.StrictMode, a warning is shown.
What should be happening?
The component should not use deprecated lifecycle methods.
Steps to reproduce issue
Error message in console
Code
Open the rendered page to see the error in the console.
The text was updated successfully, but these errors were encountered: