-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tackle issue #1349 (backward-compatible Popover behavior) #1360
Conversation
"manual" (based on the definition from bootstrap itself) seems like it would mean that the user of the library is controlling the state of |
Pre-v7, there was no trigger, so Btw, the |
|
…eractive delay={0}` The new trigger hides the popover when clicking anywhere except the target element and, depending on the new `isInteractive` prop, the popover itself. It can be combined with the `click` trigger, in which case the popover is shown when clicking the target element and hidden when clicking somewhere else. Tackles issue reactstrap#1349.
Alright, reworked so that |
Awesome, thanks for tackling this. If you can, please add some tests and update the documentation to point out this trigger which is outside of bootstrap's spec. Or, I can merge it and add the tests and update the docs. |
I'd prefer the latter ;), as I'd have to look up all the needed stuff. - Thanks! |
* 'master' of github.com:reactstrap/reactstrap: (81 commits) fix(Modal): set Modal.openCount floor to 0 (reactstrap#1368) feat(Popover): add default toggleable fade support (reactstrap#1364) (reactstrap#1364) chore(release): release 7.1.0 feat(Popover): add legacy trigger, replacing isInteractive prop feat(Popover): backward-compatible Popover behavior (reactstrap#1360) Fix(Modal): don't treat clicks on Portal children as backdrop clicks (reactstrap#1359) feat(*): support forwardRef components as tag fix(NavLink): console error while using @reach/Router (reactstrap#1350) feat(Spinner): Add spinner component (reactstrap#1352) feat(Switch): Add support for CustomInput type='switch' (reactstrap#1353) chore(release): adding 7.0.2 fix(npm): fix published files chore(release): adding 7.0.1 fix(*): fix release artifacts (reactstrap#1345) chore(release): adding 7.0.0 (reactstrap#1342) docs(typo): Fix misspelling in documentation (Alerts) (reactstrap#1329) docs(Input): static input error (reactstrap#1335) fix lint issue Bug/v7 merge conflict fix (reactstrap#1324) feat(CardBody): add innerRef to CardBody (reactstrap#1318) ...
Via
<Popover trigger="manual" isInteractive />
.Changed semantics for
trigger="manual"
: hide popover when clicking outside target element and, depending on the newisInteractive
prop, outside the popover itself.Would probably need some tests & documentation.