Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Navbar): adds NavbarText component #1711

Merged
merged 2 commits into from
Nov 19, 2019
Merged

feat(Navbar): adds NavbarText component #1711

merged 2 commits into from
Nov 19, 2019

Conversation

BamMironov
Copy link
Contributor

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

#1707

@BamMironov
feat(Navbar): adds NavbarText component
b66f0f9 
This adds a shorthand variant for <span className="navbar-text">

Closes reactstrap#1707
TheSharpieOne
TheSharpieOne requested changes Nov 19, 2019
View reviewed changes
docs/lib/Components/NavbarPage.js Outdated Show resolved Hide resolved
TheSharpieOne
TheSharpieOne approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@TheSharpieOne TheSharpieOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@TheSharpieOne TheSharpieOne merged commit 6db1083 into reactstrap:master Nov 19, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 20, 2020
Closed
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSharpieOne TheSharpieOne TheSharpieOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BamMironov @TheSharpieOne @MironovBam