Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No NavText element #1707

Closed
octylFractal opened this issue Nov 16, 2019 · 1 comment · May be fixed by largerock/largerock.com#5
Closed

No NavText element #1707

octylFractal opened this issue Nov 16, 2019 · 1 comment · May be fixed by largerock/largerock.com#5
Labels
BS compatibility enhancement good first issue

Comments

@octylFractal
Copy link

  • components: Navbar
  • reactstrap version #8.1.1
  • import method es
  • react version #16.12.0
  • bootstrap version #4.3.1

What is happening?

There is no shorthand variant for <div className="nav-text">.

What should be happening?

I expected a <NavText> component as the text-only counterpart to <NavLink>. IMO it is not a huge deal, since I don't think it has any specific configurable options, but the ability to set e.g. color would be nice.
BamMironov added a commit to BamMironov/reactstrap that referenced this issue Nov 19, 2019
@BamMironov
feat: adds NavbarText component
f04bc3f 
This adds a shorthand variant for <span className="navbar-text">

Closes reactstrap#1707
BamMironov added a commit to BamMironov/reactstrap that referenced this issue Nov 19, 2019
@BamMironov
feat(Navbar): adds NavbarText component
b66f0f9 
This adds a shorthand variant for <span className="navbar-text">

Closes reactstrap#1707
@BamMironov BamMironov mentioned this issue Nov 19, 2019
Merged
12 tasks
@BamMironov
Copy link
Contributor

@octylFractal Styles of the "navbar-text" element depend on "Nav" component styles. That is why it's better to not to add an extra prop for changing the color,

@snyk-bot snyk-bot mentioned this issue Mar 9, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BS compatibility enhancement good first issue
Projects
None yet
Milestone
No milestone
3 participants
@TheSharpieOne @octylFractal @BamMironov